Skip to content

samples: DML with Returning clause support #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 17, 2022
Merged

samples: DML with Returning clause support #2007

merged 13 commits into from
Nov 17, 2022

Conversation

rajatbhatta
Copy link
Contributor

This PR showcases how users can execute DML statements with returning clause using the Java Spanner client library, for both GoogleStandardSql and PostgreSql dialects.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 13, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 13, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Sep 13, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review September 13, 2022 14:17
@rajatbhatta rajatbhatta requested a review from a team as a code owner September 13, 2022 14:17
@rajatbhatta rajatbhatta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2022
olavloite
olavloite reviewed Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me. But aren't new samples supposed to go into separate files?

Also, I assume that we will be adding integration tests for these samples?

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 12, 2022
@rajatbhatta rajatbhatta requested a review from olavloite October 12, 2022 14:06
@rajatbhatta
Copy link
Contributor Author

@olavloite: I've made the changes based on the comments. Can you please take a look?

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 12, 2022 14:56
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
olavloite
olavloite approved these changes Oct 18, 2022
View reviewed changes
@rajatbhatta
Copy link
Contributor Author

@olavloite: Thank you for reviewing this PR :)

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@rajatbhatta rajatbhatta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2022
@rajatbhatta rajatbhatta merged commit 12a1fec into googleapis:main Nov 17, 2022
@rajatbhatta rajatbhatta deleted the returning-samples branch November 17, 2022 03:34
@rajatbhatta rajatbhatta mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatbhatta @olavloite @yoshi-kokoro